Project

General

Profile

Bug #62028

Set correct values for quotas in edit mode of new UI

Added by Vaibhav Chauhan about 1 year ago. Updated 10 months ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

As Sasha and I discussed.

add values like, 2K,1K,512, dynamically to the record size list as we need to show users with low record size their current configuration, for that probably we can dynamically add values to options list.

show a warning to users in edit mode, when users having low recordsize and implore them to move to block size > 4k,


Related issues

Related to FreeNAS - Bug #55980: Prevent setting record or block sizes below 4K and warn when changing record sizeDone
Related to FreeNAS - Bug #64530: Fix traceback when updating dataset in new UIDone
Related to FreeNAS - Bug #64563: Allow zvol creation in new UI without specifying the Block SizeDone
Has duplicate FreeNAS - Bug #67888: Zvol Creation through GUI Hangs IndefinitelyClosed
Has duplicate FreeNAS - Bug #67924: edit dataset shows wrong size units (eg. MiB instead of GiB)Closed

Associated revisions

Revision 27a1fe59 (diff)
Added by Erin Clark 10 months ago

Bring back warning about dataset recordsize > min recommended size Ticket: #62028

Revision 483a9f98 (diff)
Added by Erin Clark 10 months ago

Bring back warning about dataset recordsize > min recommended size Ticket: #62028 (cherry picked from commit 27a1fe597041b3347bc0c61c60f84615cfd1587f)

Revision 05f18a80 (diff)
Added by Erin Clark 10 months ago

Remove merge conflict markers Ticket: #62028

History

#1 Updated by Vaibhav Chauhan 12 months ago

  • Related to Bug #55980: Prevent setting record or block sizes below 4K and warn when changing record size added

#2 Updated by Vaibhav Chauhan 12 months ago

  • Status changed from Unscreened to In Progress

STABLE: https://github.com/freenas/webui/pull/1645
I wont be able to port these changes in master branch until missing form-select changes are to be ported to master branch, corresponding #64665 resolved first

#4 Updated by Dru Lavigne 12 months ago

  • Related to Bug #64530: Fix traceback when updating dataset in new UI added

#5 Updated by Vaibhav Chauhan 12 months ago

  • Related to Bug #64563: Allow zvol creation in new UI without specifying the Block Size added

#6 Updated by Dru Lavigne 11 months ago

  • Subject changed from improve Dataset recordsize to Set correct values for quotas in edit mode of new UI
  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#7 Updated by Erin Clark 11 months ago

  • Has duplicate Bug #67888: Zvol Creation through GUI Hangs Indefinitely added

#10 Updated by Dru Lavigne 11 months ago

  • Has duplicate Bug #67924: edit dataset shows wrong size units (eg. MiB instead of GiB) added

#13 Updated by Bonnie Follweiler 10 months ago

  • Status changed from Ready for Testing to Failed Testing

#15 Updated by Erin Clark 10 months ago

54417

It should show a red thing at the bottom of the screen when you select a size < 16K, this was the warning message we decided on

#16 Updated by Jeff Ervin 10 months ago

54427

Test Passed FreeNAS-11.2-U2-INTERNAL88

For creating (not editing)...

#17 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

#18 Updated by Jeff Ervin 10 months ago

  • Status changed from Done to Failed Testing
  • Needs QA changed from No to Yes

Upon further review with Erin, have changed back to Failed Testing. Zvol checked originally, but dataset Record Size creation/editing was what needed to be verified.

#19 Updated by Erin Clark 10 months ago

  • Status changed from Failed Testing to In Progress
  • Assignee changed from Vaibhav Chauhan to Erin Clark

Master PR: https://github.com/freenas/webui/pull/1912
Stable PR: https://github.com/freenas/webui/pull/1913

Testing criteria: Try to create or edit a dataset, if the record size is less than the recommended size (on my box this size was 16k) based on pool topology then a red warning should appear. The form will still save but the warning should always be there unless record size is changed to an acceptable value.

#20 Updated by Erin Clark 10 months ago

  • Status changed from In Progress to Ready for Testing

#23 Updated by Jeff Ervin 10 months ago

54498
54507

Test Passed FreeNAS-11.2-U2-INTERNAL90

Recommended minimum for my system was 16k. Set to both 4k and 8k values and saved (warning received). Upon editing the dataset, the warning does still show.

#24 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF