Project

General

Profile

Bug #62190

Bug fix for creating iocage template jail

Added by Waqar Ahmed 9 months ago. Updated 5 months ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

When we are creating a new jail and template property is set to true, jail creation fails as zfs readonly property is set to true

[root@freebsddell /home/ftp]# iocage create -r 11.2-RELEASE -n tmp template=yes
Traceback (most recent call last):
  File "/usr/local/bin/iocage", line 10, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/iocage_cli/create.py", line 152, in cli
    basejail=basejail, thickjail=thickjail, empty=empty)
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/iocage.py", line 613, in create
    clone=clone,
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_create.py", line 90, in create_jail
    return self._create_jail(jail_uuid, location)
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_create.py", line 449, in _create_jail
    open(f"{location}/fstab", "wb").close()
OSError: [Errno 30] Read-only file system: '/zroot/iocage/templates/tmp/fstab'
[root@freebsddell /home/ftp]# 

Risk
We risk breaking creating jails

Acceptance Criteria
A jail should be created without setting template prop and setting it as well. In both cases we should have a jail and with template set to true, the jail should be a template jail

Screen Shot 2019-02-28 at 11.54.29 AM.png (73.1 KB) Screen Shot 2019-02-28 at 11.54.29 AM.png Jeff Ervin, 02/28/2019 10:56 AM
Jail Temp Yes.rtf (6 KB) Jail Temp Yes.rtf Jeff Ervin, 02/28/2019 10:56 AM
57036

History

#1 Updated by Waqar Ahmed 8 months ago

#2 Updated by Bug Clerk 8 months ago

  • Status changed from In Progress to Ready for Testing

#3 Updated by Dru Lavigne 7 months ago

  • Target version changed from 11.3 to 11.3-BETA1

#4 Updated by Dru Lavigne 7 months ago

  • Subject changed from Bug fix for creating template jail to Bug fix for creating iocage template jail
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#6 Updated by Jeff Ervin 6 months ago

57036

Test Passed FreeNAS-11.3-MASTER-201902271009

To verify, ran the attached file and screenshot by Waqar, and he states this is all good.

#7 Updated by Dru Lavigne 6 months ago

  • Status changed from Passed Testing to Done

#8 Updated by Dru Lavigne 5 months ago

  • Target version changed from 11.3-BETA1 to 11.3-ALPHA1

Also available in: Atom PDF