Project

General

Profile

Bug #64563

Allow zvol creation in new UI without specifying the Block Size

Added by William Grzybowski 12 months ago. Updated 10 months ago.

Status:
Done
Priority:
No priority
Assignee:
Vaibhav Chauhan
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

When I try to create a zvol without specifying a blocksize in the UI, it sits there spinning infinitely and does not create a zvol. At the same time, middleware throws a related traceback:

[2018/12/14 16:22:44] (WARNING) application.call_method():189 - Exception while calling pool.dataset.recommended_zvol_blocksize(*['densha/perf'])
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 161, in call_method
    result = await self.middleware.call_method(self, message)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1109, in call_method
    return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1049, in _call
    return await methodobj(*args)
  File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 664, in nf
    return await f(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/pool.py", line 882, in recommended_zvol_blocksize
    pool = await self.middleware.call('pool.query', [['name', '=', pool]], {'get': True})
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1113, in call
    return await self._call(name, serviceobj, methodobj, params, app=app, pipes=pipes, io_thread=True)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1049, in _call
    return await methodobj(*args)
  File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 664, in nf
    return await f(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/service.py", line 269, in query
    filter_list, result, filters, options
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1009, in run_in_thread
    return await self.loop.run_in_executor(executor, functools.partial(method, *args, **kwargs))
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/utils/__init__.py", line 203, in filter_list
    return rv[0]
IndexError: list index out of range
[2018/12/14 16:22:44] (DEBUG) middlewared.logger.CrashReporting.report():103 - Sending a crash report...
[2018/12/14 16:22:44] (DEBUG) raven.base.Client.send_remote():716 - Sending message of length 3418 to https://sentry.ixsystems.com/api/2/store/

I did not see this behavior in 11.2-RC3 under the same conditions.

Pool and dataset layout:

root@saikyo[~]# zpool status densha
  pool: densha
 state: ONLINE
  scan: none requested
config:

        NAME                                            STATE     READ WRITE CKSUM
        densha                                          ONLINE       0     0     0
          mirror-0                                      ONLINE       0     0     0
            gptid/d3fa53a3-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
            gptid/d62e4d29-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
          mirror-1                                      ONLINE       0     0     0
            gptid/d87ba937-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
            gptid/dacca5e0-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
          mirror-2                                      ONLINE       0     0     0
            gptid/dd273d82-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
            gptid/dfb6fea1-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
          mirror-3                                      ONLINE       0     0     0
            gptid/e22f857d-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
            gptid/e4f79419-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
          mirror-4                                      ONLINE       0     0     0
            gptid/e75d9f2b-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
            gptid/e9edb9d5-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
          mirror-5                                      ONLINE       0     0     0
            gptid/ec7a6413-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
            gptid/eededa8a-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
          mirror-6                                      ONLINE       0     0     0
            gptid/f194c3a3-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
            gptid/f40b8c59-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
          mirror-7                                      ONLINE       0     0     0
            gptid/f67dd458-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0
            gptid/f909a91f-ffba-11e8-a06d-7085c255fe99  ONLINE       0     0     0

errors: No known data errors

root@saikyo[~]# zfs list -r densha
NAME                      USED  AVAIL  REFER  MOUNTPOINT
densha                    223G  3.26T    88K  /mnt/densha
densha/iocage             624K  3.26T    96K  /mnt/densha/iocage
densha/iocage/download     88K  3.26T    88K  /mnt/densha/iocage/download
densha/iocage/images       88K  3.26T    88K  /mnt/densha/iocage/images
densha/iocage/jails        88K  3.26T    88K  /mnt/densha/iocage/jails
densha/iocage/log          88K  3.26T    88K  /mnt/densha/iocage/log
densha/iocage/releases     88K  3.26T    88K  /mnt/densha/iocage/releases
densha/iocage/templates    88K  3.26T    88K  /mnt/densha/iocage/templates
densha/perf               223G  3.26T    88K  /mnt/densha/perf
densha/perf/vol0          223G  3.48T    56K  -


Related issues

Related to FreeNAS - Bug #62028: Set correct values for quotas in edit mode of new UIDone
Copied from FreeNAS - Bug #64284: cannot create zvol without specifying volblocksizeDone

History

#1 Updated by William Grzybowski 12 months ago

  • Copied from Bug #64284: cannot create zvol without specifying volblocksize added

#2 Updated by William Grzybowski 12 months ago

Erin, copied the ticket because UI should report back the error.

Also, for pool.dataset.recommended_zvol_blocksize you should only use the pool name as a parameter, not the dataset.

#3 Updated by Dru Lavigne 12 months ago

  • File deleted (debug-saikyo-20181214112040.tgz)

#4 Updated by Dru Lavigne 12 months ago

  • Subject changed from cannot create zvol without specifying volblocksize to Allow zvol creation in new UI without specifying volblocksize
  • Target version changed from Backlog to 11.2-U2
  • Private changed from Yes to No

#5 Updated by Erin Clark 12 months ago

  • Assignee changed from Erin Clark to Vaibhav Chauhan

#6 Updated by Vaibhav Chauhan 12 months ago

  • Related to Bug #62028: Set correct values for quotas in edit mode of new UI added

#7 Updated by Vaibhav Chauhan 12 months ago

  • Status changed from Unscreened to In Progress

changes for stable are in https://github.com/freenas/webui/pull/1645 PR I have made a single PR as i needed changes in the same PR and current ticket changes were small enough to be included with PR#1645

#10 Updated by Dru Lavigne 11 months ago

  • Subject changed from Allow zvol creation in new UI without specifying volblocksize to Allow zvol creation in new UI without specifying the Block Size
  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#13 Updated by Bonnie Follweiler 10 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-U2-INTERNAL84

#14 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF