Project

General

Profile

Feature #65439

Upstream `zfs send -V` -- replication status reporting in process title.

Added by Alexander Motin 8 months ago. Updated 4 months ago.

Status:
Closed
Priority:
No priority
Assignee:
Alexander Motin
Category:
OS
Target version:
Estimated time:
Severity:
Low
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Description

We have this code for years, but in context of ZoL integration would be good to upstream it, if possible.


Related issues

Related to FreeNAS - Bug #74640: Create FreeBSD / FreeNAS 12 OS branchClosed

History

#1 Updated by Alexander Motin 6 months ago

  • Related to Bug #74640: Create FreeBSD / FreeNAS 12 OS branch added

#2 Updated by Alexander Motin 6 months ago

  • Status changed from Screened to Unscreened
  • Assignee changed from Alexander Motin to Sean Fagan
  • Target version changed from Backlog to 12.0

Sean, could you look on this code. IIRC it is custom to our tree for years. We need to revisit it, possibly polish and try to push upstream (ZoL and/or FreeBSD). Otherwise, if it is bad, we will have to cary it along, that is inconvenient.

#3 Updated by Sean Fagan 6 months ago

  • Status changed from Unscreened to Screened

#4 Updated by Sean Fagan 6 months ago

That was added in commit 31bfc932ac26582a7a493b980bab31969404fcbe (by Xin); this also added the property filtering code. I don't think we want to do all of that, since I seem to recall filtering is either in ZoL from someone else, or there's a PR for it. The setproctitle part is easily separated, however.

Thoughts on that?

#5 Updated by Alexander Motin 6 months ago

I propose to discuss that with Vladimir, what of those features he needs in new replication code. Also, considering work on redacted send/receive in upstream I guess some of this functionality may be duplicate (not sure, orth checking).

#6 Updated by Sean Fagan 6 months ago

Right, the "redacted send/receive" -- that's what I was thinking of. As I recall, Matt expressed a desire to have it pushed back until after the crypto code got in, since both made significant changes to the send/receive code, and it'd probably be better to do the redaction after the crypto code.

#7 Updated by Alexander Motin 6 months ago

After close look, it seems like V was added by different commit - 6295db3c947b8e0c7b941eb004d460753d33524f also by Xin.

#8 Updated by Sean Fagan 6 months ago

That commit is incomplete -- it doesn't have the code to call setproctitle(), for example. But the one it was cherry-picked from -- 13cc5237d6dbed102722cf4d3655783ee7e32fa5 -- does. And doesn't have as much as the one I found via git blame.

So I think that's the one to use.

#9 Updated by Alexander Motin 6 months ago

I suppose that code could be rewritten several times during different merges, so none of commits may cover the final version completely. :)

#10 Updated by Sean Fagan 6 months ago

  • Status changed from Screened to In Progress

Differential revision https://reviews.freebsd.org/D19184 for freebsd.

I still have no idea how to do even a sanity build on Illumos so that's out.

ZoL pull request https://github.com/zfsonlinux/zfs/pull/8418

#11 Updated by Dru Lavigne 5 months ago

  • Assignee changed from Sean Fagan to Alexander Motin

#12 Avatar?id=14398&size=24x24 Updated by Kris Moore 4 months ago

  • Status changed from In Progress to Closed

Also available in: Atom PDF