Project

General

Profile

Bug #66936

Use constants defined in ZFS Header

Added by Waqar Ahmed 3 months ago. Updated about 1 month ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Severity:
Low
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

For accessing data in zfs nvlists, we declare strings on the go and use them for fetching different data from the nvlist. However this is not ideal and we should be using consts defined in zfs header as this will reduce chances of error where we mistakingly change a key's name and also help increase readability and improve our py-libzfs code base in general


Related issues

Copied to FreeNAS - Bug #72715: Use constants defined in ZFS HeaderClosed

Associated revisions

Revision ac52656a (diff)
Added by Waqar Ahmed 2 months ago

Use constants defined in zfs header

This commit introduces changes to most of the strings which have been defined on the go and could be imported from zfs header. We import them from zfs header now to make the code base more consistent and also avoid potential errors in the future.
Ticket: #66936

History

#1 Updated by Waqar Ahmed 2 months ago

  • Status changed from Screened to In Progress

#2 Updated by Waqar Ahmed 2 months ago

  • Status changed from In Progress to Ready for Testing

#3 Updated by Dru Lavigne about 2 months ago

  • Target version changed from 11.3 to 11.3-BETA1

#4 Updated by Dru Lavigne about 2 months ago

  • Subject changed from Use Nvlist keys from ZFS Header to Use constants defined in ZFS Header
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#5 Updated by Erin Clark about 2 months ago

  • Copied to Bug #72715: Use constants defined in ZFS Header added

#6 Updated by Waqar Ahmed about 1 month ago

This ticket can be marked as done as testing is not ideal for this ticket. In case there are any issues, we would not have a working build of freenas as py-libzfs port would have failed

#7 Updated by Dru Lavigne about 1 month ago

  • Status changed from Ready for Testing to Done
  • Target version changed from 11.3-BETA1 to Master - FreeNAS Nightlies
  • Needs QA changed from Yes to No

Also available in: Atom PDF