Project

General

Profile

Bug #71147

Allow dashes, periods, and underscores in group name in new UI

Added by IT IGP almost 3 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
-
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Trying to create a new group with a hyphen/dash in the name, e.g. "my-group" is not accepted. This is not in line with old UI and freebsd allowed chars.

Screenshot_14.png (38.2 KB) Screenshot_14.png IT IGP, 01/21/2019 11:00 AM
Screenshot_13.png (39.5 KB) Screenshot_13.png IT IGP, 01/21/2019 11:00 AM
Screenshot_15.png (35.8 KB) Screenshot_15.png IT IGP, 01/21/2019 11:00 AM
Screen Shot 2019-03-07 at 9.56.44 AM.png (39 KB) Screen Shot 2019-03-07 at 9.56.44 AM.png Jeff Ervin, 03/07/2019 06:59 AM
Screen Shot 2019-03-07 at 9.57.38 AM.png (44.4 KB) Screen Shot 2019-03-07 at 9.57.38 AM.png Jeff Ervin, 03/07/2019 06:59 AM
Screen Shot 2019-03-12 at 10.17.29 AM.png (34.4 KB) Screen Shot 2019-03-12 at 10.17.29 AM.png Jeff Ervin, 03/12/2019 07:24 AM
Screen Shot 2019-03-12 at 10.21.02 AM.png (34.6 KB) Screen Shot 2019-03-12 at 10.21.02 AM.png Jeff Ervin, 03/12/2019 07:24 AM
50121
50129
50137
59538
59547
60537
60546

Associated revisions

Revision 4c383016 (diff)
Added by Erin Clark almost 3 years ago

Adjust group name regex to allow dashes and periods Ticket: #71147

Revision 6f6b0445 (diff)
Added by Erin Clark almost 3 years ago

Adjust group name regex to allow dashes and periods Ticket: #71147 Signed-off-by: Erin Clark <erin@ixsystems.com>

Revision f6bee5c9 (diff)
Added by Erin Clark almost 3 years ago

Allow underscores in group names similar to how we allow them in user names Ticket: #71147

Revision 8ab48be7 (diff)
Added by Erin Clark almost 3 years ago

Allow underscores in group names similar to how we allow them in user names Ticket: #71147 (cherry picked from commit f6bee5c92260a30e0685d8d3f1212a63b03a4d7f)

History

#1 Updated by IT IGP almost 3 years ago

this behaviour seems to apply to an updated system 11.1u6 => 11.2.

on a fresh 11.2 "-" is allowed. strange.

#2 Updated by Dru Lavigne almost 3 years ago

  • Status changed from Unscreened to Blocked
  • Private changed from No to Yes
  • Reason for Blocked set to Need additional information from Author

Please recreate then attach a debug (System -> Advanced -> Save debug) to this ticket.

#3 Updated by IT IGP almost 3 years ago

50121
50129
50137

attached screenshot while editing the name field. also debug.

#4 Updated by Dru Lavigne almost 3 years ago

  • Status changed from Blocked to Unscreened
  • Assignee changed from Release Council to Anonymous
  • Target version changed from Backlog to 11.2-U3
  • Reason for Blocked deleted (Need additional information from Author)

#5 Updated by Anonymous almost 3 years ago

  • Status changed from Unscreened to In Progress

#6 Updated by Dru Lavigne almost 3 years ago

  • File deleted (debug-samba-20190121195837.tgz)

#7 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from new group name cannot contain hyphen/dash anymore to Allow dashes and periods in group name in new UI
  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#8 Updated by Dru Lavigne almost 3 years ago

  • Private changed from Yes to No

#9 Updated by IT IGP almost 3 years ago

... and underscore "_" i hope, too? seems blocked in 11.2u2.

pw groupadd -n _myGroup-fine

works fine...

#10 Updated by Anonymous almost 3 years ago

  • Status changed from Ready for Testing to Unscreened

I'll add _ characters for U3

#11 Updated by Anonymous almost 3 years ago

  • Subject changed from Allow dashes and periods in group name in new UI to Allow dashes, periods and underscores in group name in new UI
  • Status changed from Unscreened to In Progress

#12 Updated by Anonymous almost 3 years ago

Testing criteria: _ characters are allowed anywhere in the group name, . and - are allowed in the group name but not as the first character

#13 Updated by Anonymous almost 3 years ago

  • Status changed from In Progress to Ready for Testing

#15 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Allow dashes, periods and underscores in group name in new UI to Allow dashes, periods, and underscores in group name in new UI

#17 Updated by Jeff Ervin over 2 years ago

59538
59547

Erin Clark wrote:

Testing criteria: _ characters are allowed anywhere in the group name, . and - are allowed in the group name but not as the first character

Hey Erin, see the screenshots, if you would. Everything checks out with the exception of "." at the beginning of the name. I can create a name with the period at the beginning. What would you like me to do here? Thanks

#18 Updated by Jeff Ervin over 2 years ago

60537
60546

Test Passed FreeNAS-11.2-U2-INTERNAL98

In INTERNAL 98, "." and "-" will not save under the name for a group (beginning with these characters). Checked all other scenarios (as outlined in earlier internals / screenshots) to ensure no regression.

Also available in: Atom PDF