Project

General

Profile

Bug #71337

Use a split instead of a regex to find the poolname for zvol blocksize

Added by Aaron St. John 11 months ago. Updated 10 months ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Seen in FreeNAS-11.2-INTERNAL72

To recreate the issue, click three dot menu under a pool. Click "Add zvol". Enter name and a size. Click "Save". The WebUI hangs there indefinitely and does not create a zvol.


Related issues

Related to FreeNAS - Bug #69168: Store zvol size value for use by new UIDone
Related to FreeNAS - Bug #72025: Fix dataset creation in new UI for pools with a number in their nameDone
Has duplicate FreeNAS - Bug #73083: Unable to add ZVOL from new UIClosed
Copied to FreeNAS - Bug #71379: Prevent new UI from hanging when creating a zvol Done

Associated revisions

Revision 84a02d35 (diff)
Added by Erin Clark 11 months ago

Use a split instead of a regex to find the poolname Ticket: #71337

History

#1 Updated by Aaron St. John 11 months ago

  • File debug-freenas-20190121123857.tgz added

#2 Updated by William Grzybowski 11 months ago

  • Category changed from Middleware to GUI (new)
  • Assignee changed from William Grzybowski to Erin Clark
  • Target version changed from Backlog to 11.2-U3

Erin, seems to be an UI issue. I can create using midclt.

#3 Updated by Dru Lavigne 11 months ago

  • Target version changed from 11.2-U3 to 11.2-U2

#4 Updated by Erin Clark 11 months ago

  • Category changed from GUI (new) to Middleware
  • Assignee changed from Erin Clark to William Grzybowski

I see this happening in the webui:

reason: "[ENOENT] Pool not found."

trace: {…}
​​
class: "CallError"
​​
formatted: "Traceback (most recent call last):\n File \"/usr/local/lib/python3.6/site-packages/middlewared/main.py\", line 165, in call_method\n result = await self.middleware.call_method(self, message)\n File \"/usr/local/lib/python3.6/site-packages/middlewared/main.py\", line 1141, in call_method\n return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)\n File \"/usr/local/lib/python3.6/site-packages/middlewared/main.py\", line 1081, in _call\n return await methodobj(*args)\n File \"/usr/local/lib/python3.6/site-packages/middlewared/schema.py\", line 664, in nf\n return await f(*args, **kwargs)\n File \"/usr/local/lib/python3.6/site-packages/middlewared/plugins/pool.py\", line 884, in recommended_zvol_blocksize\n raise CallError('Pool not found.', errno.ENOENT)\nmiddlewared.service_exception.CallError: [ENOENT] Pool not found.\n"

Which I seems to be happening happening when this call is being made to get the recommended blocksize 'pool.dataset.recommended_zvol_blocksize', since the blocksize is not discovered and not set the form errors out. If I manually set the blocksize the call succeeds and creates a zvol.

It is also only doing this for one of the two pools on the box this originates from and not the other one, it seems the middleware just doesn't like that pool for some reason. Could you look into this William?

#5 Updated by William Grzybowski 11 months ago

  • Assignee changed from William Grzybowski to Erin Clark

Because it was not found. Please pass the correct parameter to the pool.dataset.recommended_zvol_blocksize call.

#6 Updated by William Grzybowski 11 months ago

  • Category changed from Middleware to GUI (new)

#8 Updated by Erin Clark 11 months ago

Stable PR: https://github.com/freenas/webui/pull/1813

Master needs to be investigated to see if the same thing needs to be done there, the form and presumably the zvol create call are different there. (And the regex doesn't exist there either)

#9 Updated by Erin Clark 11 months ago

  • Copied to Bug #71379: Prevent new UI from hanging when creating a zvol added

#10 Updated by Erin Clark 11 months ago

  • Status changed from Unscreened to Ready for Testing
  • Needs Merging changed from Yes to No

#11 Updated by Dru Lavigne 11 months ago

  • File deleted (debug-freenas-20190121123857.tgz)

#12 Updated by Dru Lavigne 11 months ago

  • Subject changed from WebUI hanging when creating zvol under pool to Use a split instead of a regex to find the poolname for zvol blocksize
  • Seen in changed from TrueNAS 11.2-U3 to 11.2-RELEASE-U1
  • Needs Doc changed from Yes to No

#16 Updated by Erin Clark 11 months ago

Testing criteria: This was failing on pools that have a number in the name specifically, create a pool with a number in it like "pool1" and attempt to create a zvol on it.

#18 Updated by Bonnie Follweiler 11 months ago

  • Related to Bug #69168: Store zvol size value for use by new UI added

#20 Updated by Bonnie Follweiler 10 months ago

  • Status changed from Ready for Testing to Passed Testing

Test Passed in FreeNAS-11.2-U2-INTERNAL81

#21 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done
  • Needs QA changed from Yes to No

#22 Updated by Dru Lavigne 10 months ago

  • Has duplicate Bug #73083: Unable to add ZVOL from new UI added

#23 Updated by Erin Clark 10 months ago

  • Related to Bug #72025: Fix dataset creation in new UI for pools with a number in their name added

Also available in: Atom PDF