Project

General

Profile

Bug #74686

Change "Container Provider" to a single constant defined as "Docker Host"

Added by Timothy Moore II 2 months ago. Updated about 1 month ago.

Status:
Done
Priority:
No priority
Assignee:
Timothy Moore II
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

The term "Container Provider" is being changed as part of a broader unification of terms to "Docker Host". "Container Provider" is being named is several different locations in the middleware. Could a constant for the term "Docker Host" be defined in a central location and then individual references to "Container Provider" changed to point to the constant?

new-ui-container-provider.png (52.2 KB) new-ui-container-provider.png Timothy Moore II, 02/19/2019 07:48 AM
Screen Shot 2019-03-07 at 12.35.53 PM.png (96.2 KB) Screen Shot 2019-03-07 at 12.35.53 PM.png Jeff Ervin, 03/07/2019 09:39 AM
55030
59745

Related issues

Related to FreeNAS - Bug #72755: Unify term for "Docker Host" Virtual Machines in new UIDone

History

#1 Updated by Timothy Moore II 2 months ago

  • Related to Bug #72755: Unify term for "Docker Host" Virtual Machines in new UI added

#2 Updated by Timothy Moore II 2 months ago

  • Subject changed from Change "Container Provider" to a variable to Change "Container Provider" to a single constant defined as "Docker Host"

#3 Updated by Dru Lavigne 2 months ago

  • Assignee changed from Release Council to Vladimir Vinogradenko

#4 Updated by Vladimir Vinogradenko about 2 months ago

  • Assignee changed from Vladimir Vinogradenko to William Grzybowski

#5 Updated by William Grzybowski about 2 months ago

  • Status changed from Unscreened to Blocked
  • Reason for Blocked set to Need additional information from Author

Why does it matter how it is called in the middleware/backend? This is just a bad way to break the API compatibility.

Why cant just the UI be changed to reflect what the Docs team want? It could be called XYZ in the backend and it wouldnt matter to the end user.

#6 Updated by Timothy Moore II about 2 months ago

55030

When I updated the new UI there was one location where the "Container Provider" text is being pulled in directly from the middleware (screenshot).
It was also recommended to update the legacy UI at the same time so the "Docker Host" term would be unified across both user interfaces. Because this involves setting up a defined term and making changes to freenas/freenas files, I was told to open a ticket to request the change.

#7 Updated by William Grzybowski about 2 months ago

Thats a constant that comes from the middleware like many others (e.g. cloud sync SYNC, COPY) and it should be treated as such by the new UI. The UI should probably transform these kind of values to something that makes sense to the user using some sort of mapping with translation.

#8 Updated by Timothy Moore II about 2 months ago

  • Category changed from Middleware to GUI (new)
  • Status changed from Blocked to In Progress
  • Assignee changed from William Grzybowski to Timothy Moore II
  • Target version changed from Backlog to 11.2-U3
  • Reason for Blocked deleted (Need additional information from Author)

Investigated with Dennis' help and found a simple way to transform the text in the new UI.

Opened PRs https://github.com/freenas/webui/pull/1976 and https://github.com/freenas/webui/pull/1977

Testing: go to the Virtual Machines page and confirm the VM Type field reads as "Bhyve" or "Docker Host".
Docs: Verify no reference to "Container Provider" exists in the FreeNAS Guide Virtual Machines section (angulargui branch only).

#9 Updated by Erin Clark about 2 months ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#12 Updated by Jeff Ervin about 1 month ago

59745

Test Passed FreeNAS-11.2-U2-INTERNAL95

Also, conducted a search of the Guide, found no reference to "Container Provider" within the VM section

#13 Updated by Dru Lavigne about 1 month ago

  • Status changed from Passed Testing to Done
  • Needs Doc changed from Yes to No

Also available in: Atom PDF