Project

General

Profile

Bug #75423

Adjust VM name validator in new UI to not allow spaces

Added by Bonnie Follweiler almost 3 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
-
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

I created a VM in the New GUI, in FreeNAS-11.2-U2 with a space in the name
The Wizard walked me through all the windows to the end and then informed me that the name was invalid. Rather than start all over again I backed up all the screens to the beginning to change the space to an underscore and then walked through (with all my values intact)

Would it be possible to add a warning if the name given to a VM is going to be invalid?

Associated revisions

Revision f60f7aa8 (diff)
Added by Erin Clark almost 3 years ago

Adjust vm wizard name regex to not allow spaces Ticket: #75423

Revision 99abb66d (diff)
Added by Erin Clark almost 3 years ago

Adjust vm wizard name regex to not allow spaces Ticket: #75423 (cherry picked from commit f60f7aa8a285ebe923713d5b594a2733908684c8)

History

#1 Updated by Bonnie Follweiler almost 3 years ago

  • Subject changed from In teh new GUI could we add a VM naming validater in the wizard to In the new GUI could we add a VM naming validater in the wizard

#2 Updated by Dru Lavigne almost 3 years ago

  • Target version changed from Backlog to 11.2-U3

#3 Updated by Anonymous almost 3 years ago

  • Subject changed from In the new GUI could we add a VM naming validater in the wizard to VM Name validator should not allow spaces
  • Status changed from Unscreened to In Progress

It seems the problem was that the regex was allowing spaces, it should have been checking for \_ (since _ characters are allowed) instead of _ which matches spaces and _.

Stable PR: https://github.com/freenas/webui/pull/1948
Master PR: https://github.com/freenas/webui/pull/1947

#5 Updated by Anonymous almost 3 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#6 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from VM Name validator should not allow spaces to Adjust VM name validator in new UI to not allow spaces

#9 Updated by Bonnie Follweiler over 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed inFreeNAS-11.2-U2-INTERNAL97

#11 Updated by Dru Lavigne over 2 years ago

  • Status changed from Passed Testing to Done
  • Needs Doc changed from Yes to No

Also available in: Atom PDF