Project

General

Profile

Bug #76161

Do not display status for exported pools

Added by Brandon Schneider 10 months ago. Updated 8 months ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Severity:
High
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

https://pastebin.com/NaS068Ef and https://pastebin.com/WgFJR5kB show the stacktraces, can be replicated by having two pools and doing midclt call zfs.pool.find_import

Could possibly be the result of https://github.com/freenas/py-libzfs/commit/255b61d1aa74aba80fcbf1ff6240803f66cce0fb

Associated revisions

Revision 79a6c49f (diff)
Added by Waqar Ahmed 10 months ago

Donot display status for exported pools This commit makes sure that we don't display status for exported pools because in that case handle is not set resulting in segementation fault. Ticket: #76161

History

#1 Updated by Brandon Schneider 10 months ago

  • Subject changed from libzfs is not happy with zfs_get_status to libzfs is not happy with zpool_get_status

#2 Updated by Waqar Ahmed 10 months ago

  • Status changed from Unscreened to In Progress

#3 Updated by Waqar Ahmed 10 months ago

  • Status changed from In Progress to Ready for Testing

Acceptance Criteria
It should be ensured we have two pools. With two pools, any one of them can be exported. After one of them has been exported, `midclt call zfs.pool.find_import` should be run and ensured that it doesn't fail.

#4 Updated by Dru Lavigne 10 months ago

  • Subject changed from libzfs is not happy with zpool_get_status to Do not display status for exported pools
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#6 Updated by William Grzybowski 10 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Tested in FreeNAS-11.3-MASTER-201902220754

#7 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

#8 Updated by Dru Lavigne 8 months ago

  • Target version changed from 11.3-BETA1 to 11.3-ALPHA1

Also available in: Atom PDF