Project

General

Profile

Bug #77097

Do not list unavailable disks when replacing a disk

Added by David Johnson almost 3 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

I have seen the replacement drive dropdown list fail to display available replacement disks. This issue was seen while trying to replace a failing drive. Steps taken were as follows

  1. Navigated to Storage->Pools selected pool with failing drive ->Status
  2. Selected failing drive `da3p2` and selected Offline
  3. Turned off machine and replaced the drive with a new, known-functional drive
  4. Rebooted machine and navigated to Storage->Pools->Status
  5. Observed `da0p2`, `da1p2`, `da2p2`, `da3p2`, `/dev/gptid/6baa8a5e-2f8d-11e9-89f4-ac1f6b855b2c`, and `da5p2`
  6. Selected `/dev/gptid/6baa8a5e-2f8d-11e9-89f4-ac1f6b855b2c` and clicked replace
    Expected: The new device should appear in the drop down list to select as a replacement drive and begin resilvering
    Actual: The new drive never appeared in the dropdown. The disk selection prompt remained blue and clicking the drop down arrow or the words never displayed a list of replacement drive. It was confirmed that the new drive was recognized by the system. S.M.A.R.T. data was returned for the drive in question

I turned the computer off, put the old drive back in, turned it back on and was able to navigate to the pool's disks and mark the disk as "ONLINE". This brought the pool to a HEALTHY state.

I once again followed the steps outlined above except that I did not reboot the computer to perform the swap, instead I hot-swapped the disk. The problem persisted, no new drive was available from the replacement list. After 5 or 10 minutes and several other times clicking into the replace screen I was finally able to see a list of available replacement drives. I selected the replacement drive and resilvering began and completed without error.

I am running
OS Version:
FreeNAS-11.2-U2
(Build Date: Feb 14, 2019 20:8)

The two HDDs in question
(Failed Drive) Seagate Constellation ES.3 ST3000NM0033-9ZM178
(Replacement Drive) Seagate IronWolf ST3000VN007-2E4166
HBA: LSI SAS9207 Firmware 20.00.07.00

offline.png (24 KB) offline.png Bonnie Follweiler, 03/06/2019 12:51 PM
offlined disk.png (44.4 KB) offlined disk.png Bonnie Follweiler, 03/06/2019 12:52 PM
59160
59187

Associated revisions

Revision 96307671 (diff)
Added by William Grzybowski almost 3 years ago

Do not return UNAVAIL/OFFLINE disks Ticket: #77097

History

#1 Updated by Anthony Takata almost 3 years ago

(Not a dev) I think this would be a good case to attach the debug package (System tab, Advanced, Save Debug button). When doing so set to private to be safe until they can analyse it.

Personally I've had this issue happen when the replacement disk wasn't cleaned (i.e. it was in a broken pool previously) but I'm not sure if this is the case here.

#2 Updated by David Johnson almost 3 years ago

  • File debug-dorothy-20190225163927.tgz added
  • Private changed from No to Yes

Adding debug file in case it is helpful.

#3 Updated by Anonymous almost 3 years ago

  • Assignee changed from Release Council to Anonymous
  • Target version changed from Backlog to 11.2-U3

#4 Updated by Anonymous almost 3 years ago Private

I will attempt to reproduce on my box

#5 Updated by Anonymous almost 3 years ago

  • Assignee changed from Anonymous to William Grzybowski

I attempted to do a disk replace on my box to see if I could reproduce this but it seems to just work for me. William, what are your thoughts on this?

#6 Updated by William Grzybowski almost 3 years ago

  • Assignee changed from William Grzybowski to Anonymous

#8 Updated by Anonymous almost 3 years ago

  • Assignee changed from Anonymous to William Grzybowski

#9 Updated by Anonymous almost 3 years ago Private

The disk list is populated by disk.get_unused, the replacing action itself is done with the rest call "storage/volume/" + this.pk + "/replace"

#10 Updated by William Grzybowski almost 3 years ago

  • Category changed from GUI (new) to Middleware
  • Status changed from Unscreened to Ready for Testing

#11 Updated by Dru Lavigne almost 3 years ago

  • File deleted (debug-dorothy-20190225163927.tgz)

#12 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from Unable to Select New Disk to Replace Drive to Do not list UNAVAIL/OFFLINE disks when replacing a disk
  • Private changed from Yes to No
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#18 Updated by Bonnie Follweiler over 2 years ago

59160
59187

Running Ubuntu in Chromium on FreeNAS-11.2-U2-INTERNAL94
I offlined ada4 yet was still available to select it from the replacement list for another pool

#19 Updated by William Grzybowski over 2 years ago

  • Status changed from Failed Testing to Passed Testing

Read my last comment.

#20 Updated by Bonnie Follweiler over 2 years ago

  • Needs QA changed from Yes to No

Thank you William, In that case Test Passed in FreeNAS-11.2-U2-INTERNAL94

#21 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Do not list UNAVAIL/OFFLINE disks when replacing a disk to Do not list unavailable disks when replacing a disk
  • Status changed from Passed Testing to Done

Also available in: Atom PDF