Project

General

Profile

Bug #77917

Properly set and save dataset inherit values in new UI

Added by Marco . over 2 years ago. Updated over 2 years ago.

Status:
Ready for Testing
Priority:
No priority
Assignee:
-
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Compression level, deduplication and readonly are set to “Inherit” (see screenshot) on a dataset. However, after saving the source is set to “local” instead of “inherited from tank”:

root@freenas[~]# zfs get compression tank/work/mhp-data
NAME                PROPERTY     VALUE     SOURCE
tank/work/mhp-data  compression  lz4       local
datasets.png (79.6 KB) datasets.png Marco ., 02/28/2019 07:49 AM
inheritance-01.png (58.6 KB) inheritance-01.png Marco ., 02/28/2019 07:49 AM
56938
56947

Associated revisions

Revision 96750ff2 (diff)
Added by Erin Clark over 2 years ago

Dataset options form should now properly set and save inherit values Ticket: #77917

Revision cf185b9e (diff)
Added by Erin Clark over 2 years ago

Fix copy-pasto errors Ticket: #77917

Revision 435dd3aa (diff)
Added by Erin Clark over 2 years ago

Dataset options form should now properly set and save inherit values Ticket: #77917 (cherry picked from commit 96750ff2b75cb4b4da0b967170f58f420c1d9d5b)

Revision 4f47066d (diff)
Added by Erin Clark over 2 years ago

Fix copy-pasto errors Ticket: #77917 (cherry picked from commit cf185b9e0b494dd2963855f907576271bcb209fd)

Revision 22833670 (diff)
Added by Erin Clark over 2 years ago

11.3 Gzip-6 is just Gzip Ticket: #77917

Revision 281e229d (diff)
Added by Erin Clark over 2 years ago

Treat default and inherited both as inherited sources as per request Ticket: #77917

Revision 585d6b14 (diff)
Added by Erin Clark over 2 years ago

Treat default and inherited both as inherited sources as per request Ticket: #77917 (cherry picked from commit 281e229d73670b5d131ec6de7125d9b86d8daf39)

History

#1 Updated by Dru Lavigne over 2 years ago

  • Private changed from No to Yes
  • Reason for Blocked set to Need additional information from Author

Marco: please attach a debug (System -> Advanced -> Save debug) to this ticket.

#2 Updated by Marco . over 2 years ago

  • File debug-freenas-20190305151728.tgz added

Dru Lavigne wrote:

Marco: please attach a debug (System -> Advanced -> Save debug) to this ticket.

done

#3 Updated by Dru Lavigne over 2 years ago

  • Category changed from GUI (new) to Middleware
  • Assignee changed from Release Council to William Grzybowski
  • Reason for Blocked deleted (Need additional information from Author)

#5 Updated by William Grzybowski over 2 years ago

  • Category changed from Middleware to GUI (new)
  • Assignee changed from William Grzybowski to Anonymous
  • Target version changed from Backlog to 11.2-U4

#7 Updated by Anonymous over 2 years ago

  • Status changed from Unscreened to In Progress

Stable PR: https://github.com/freenas/webui/pull/2060
Master PR: https://github.com/freenas/webui/pull/2059

Testing criteria: Sections that have inherit as an option should save the inherit value properly when editing an existing dataset

#8 Updated by Anonymous over 2 years ago

  • File deleted (debug-freenas-20190305151728.tgz)

#9 Updated by Anonymous over 2 years ago

  • Private changed from Yes to No

#10 Updated by Anonymous over 2 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#11 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Setting dataset properties to “Inherit” doesn't inherit to Properly set and save dataset inherit values in new UI
  • Needs Doc changed from Yes to No

Also available in: Atom PDF