Project

General

Profile

Bug #79482

Fix but that prevented the removal of snapshot tasks from SMB shares

Added by Andrew Walker over 2 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Andrew Walker
Category:
Middleware
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Users should be able to remove snapshot tasks from shares. This ticket handles middleware change. We need corresponding change to New UI to allow disabling snapshots there as well.


Related issues

Related to FreeNAS - Bug #82578: Allow a snapshot task to be deleted in an smb share in the New GUIClosed

History

#1 Updated by Bug Clerk over 2 years ago

  • Status changed from Unscreened to In Progress

#2 Updated by William Grzybowski over 2 years ago

  • Target version changed from Backlog to 11.2-U4

#3 Updated by Bug Clerk over 2 years ago

  • Status changed from In Progress to Ready for Testing

#4 Updated by Dru Lavigne over 2 years ago

  • Target version changed from 11.2-U4 to 11.2-U3

#6 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Cannot remove snapshot task from old UI. to Fix but that prevented the removal of snapshot tasks from SMB shares
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#8 Updated by Bonnie Follweiler over 2 years ago

  • Status changed from Ready for Testing to Failed Testing

Request Method: POST
Request URL: http://fn07.lab.ixsystems.com/legacy/admin/sharing/cifs_share/edit/8/
Software Version: FreeNAS-11.2-U2-INTERNAL102 (d085aead2)
Exception Type: ClientException
Exception Value:

int() argument must be a string, a bytes-like object or a number, not 'dict'

Exception Location: /usr/local/lib/python3.6/site-packages/middlewared/client/client.py in call, line 454
Server time: Mon, 18 Mar 2019 16:18:29 -0400

Traceback
Environment:

Software Version: FreeNAS-11.2-U2-INTERNAL102 (d085aead2)
Request Method: POST
Request URL: http://fn07.lab.ixsystems.com/legacy/admin/sharing/cifs_share/edit/8/

Traceback:
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
42. response = get_response(request)
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py" in legacy_get_response
249. response = self._get_response(request)
File "/usr/local/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
178. response = middleware_method(request, callback, callback_args, callback_kwargs)
File "./freenasUI/freeadmin/middleware.py" in process_view
163. return login_required(view_func)(request, *view_args, **view_kwargs)
File "/usr/local/lib/python3.6/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
23. return view_func(request, *args, **kwargs)
File "./freenasUI/freeadmin/options.py" in wrapper
216. return self._admin.admin_view(view)(*args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/django/utils/decorators.py" in _wrapped_view
149. response = view_func(request, *args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/django/views/decorators/cache.py" in _wrapped_view_func
57. response = view_func(request, *args, **kwargs)
File "./freenasUI/freeadmin/site.py" in inner
143. return view(request, *args, **kwargs)
File "./freenasUI/freeadmin/options.py" in edit
578. mf.save()
File "./freenasUI/middleware/form.py" in save
55. result = self.
_save()
File "./freenasUI/middleware/form.py" in __save
114. raise
File "./freenasUI/middleware/form.py" in __save
109. return c.call(f"{self.middleware_plugin}.{self._middleware_action}", *args, **kwargs)
File "/usr/local/lib/python3.6/site-packages/middlewared/client/client.py" in call
454. raise ClientException(c.error, c.errno, c.trace, c.extra)

Exception Type: ClientException at /legacy/admin/sharing/cifs_share/edit/8/
Exception Value: int() argument must be a string, a bytes-like object or a number, not 'dict'

Request information
GET

No GET data
POST
Variable Value
all ''
cifs_path '/mnt/tankity/testset'
cifs_name 'testset'
cifs_comment ''
cifs_browsable 'on'
cifs_hostsallow ''
cifs_hostsdeny ''
selecAt_from 'xattr_tdb'
cifs_vfsobjects 'streams_xattr'
cifs_storage_task ''
cifs_auxsmbconf ''
__form_id 'dialogForm_cifs_share'
FILES

No FILES data
COOKIES
Variable Value
fntreeSaveStateCookie 'root%2Croot%2F1%2Croot%2F1%2F7'
referrer 'https://www.ixsystems.com/'
_ga 'GA1.2.41536575.1551716182'
_fbp 'fb.1.1551716182695.969664566'
_mkto_trk 'id:855-MUM-343&token:_mch-ixsystems.com-1551716182756-63286'
csrftoken '********'
sessionid '1eg983301d179s37x4xb9f7632ytxjw8'
META
Variable Value

#11 Updated by Bug Clerk over 2 years ago

  • Status changed from Failed Testing to In Progress

#12 Updated by Bug Clerk over 2 years ago

  • Status changed from In Progress to Ready for Testing

#13 Updated by Bonnie Follweiler over 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-U2-INTERNAL104

#14 Updated by Dru Lavigne over 2 years ago

  • Status changed from Passed Testing to Done

#16 Updated by Dru Lavigne over 2 years ago

  • Related to Bug #82578: Allow a snapshot task to be deleted in an smb share in the New GUI added

Also available in: Atom PDF