Project

General

Profile

Bug #8078

Disable Sendfile

Added by Joshua Ruehlig over 5 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
Josh Paetzel
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

I wasn't sure how best to bring attention to my Pull Request on github.
https://github.com/freenas/freenas/pull/88

This is a very small change with a small benefit and no risk.

Associated revisions

Revision c65f6102 (diff)
Added by Josh Paetzel over 5 years ago

Disable sendfile Ticket: #8078

Revision 8cf06704 (diff)
Added by Josh Paetzel over 5 years ago

Disable sendfile Ticket: #8078 (cherry picked from commit c65f610258befbdef786cf775cb175bec4ad301a)

History

#1 Updated by Joshua Ruehlig over 5 years ago

  • Category set to 2

#2 Updated by Jordan Hubbard over 5 years ago

Do we know what the benefit is? I mean, can we quantify it in any way?

#3 Updated by Joshua Ruehlig over 5 years ago

Jordan Hubbard wrote:

Do we know what the benefit is? I mean, can we quantify it in any way?

I'm not an expert, but I believe it has to do with the fact that ZFS as a filesystem already caches files so there's no benefit it also using the sendfile() call which would get it from the kernel cache (you can tell I'm stuggling here =] ).
The PDF is a powerpoint from this talk https://www.youtube.com/watch?v=PIpI7Ub6yjo

Is there a reason you want to keep sendfile enabled? NGINX has it disabled by default (deleting the line would give the same result), and I believe it has no benefit when serving files from ZFS.

#4 Updated by Jordan Hubbard over 5 years ago

  • Assignee set to Josh Paetzel
  • Target version set to Unspecified

#5 Updated by Josh Paetzel over 5 years ago

  • Status changed from Unscreened to Ready For Release

#6 Updated by Jordan Hubbard over 5 years ago

  • Status changed from Ready For Release to Resolved

#7 Avatar?id=14398&size=24x24 Updated by Kris Moore about 4 years ago

  • Target version changed from Unspecified to N/A

Also available in: Atom PDF