I wasn't sure how best to bring attention to my Pull Request on github.
This is a very small change with a small benefit and no risk.
#3 Updated by Joshua Ruehlig over 5 years ago
Jordan Hubbard wrote:
Do we know what the benefit is? I mean, can we quantify it in any way?
I'm not an expert, but I believe it has to do with the fact that ZFS as a filesystem already caches files so there's no benefit it also using the sendfile() call which would get it from the kernel cache (you can tell I'm stuggling here =] ).
The PDF is a powerpoint from this talk https://www.youtube.com/watch?v=PIpI7Ub6yjo
Is there a reason you want to keep sendfile enabled? NGINX has it disabled by default (deleting the line would give the same result), and I believe it has no benefit when serving files from ZFS.