Project

General

Profile

Bug #81399

Allow/Deny Hosts in Services / RSYNCModule / Rsync doesn't work properly

Added by Chris Jensen over 2 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Seen in:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

The GUI adds brackets [] on both Allow an Deny Hosts every time saved, and continues to add additional brackets every time saved again. And it seems like these brackets, especially when nothing is specified, prevents the filter from working properly. Everything works properly when removing these brackets in /usr/local/etc/rsyncd.conf.

allowhosts.png (27.2 KB) allowhosts.png Chris Jensen, 03/16/2019 03:21 PM
61401

Related issues

Copied to FreeNAS - Bug #82713: Validate Allow/Deny Hosts fields in Services -> Rsync -> Rsync ModuleReady for Testing

Associated revisions

Revision 08c10438 (diff)
Added by Waqar Ahmed over 2 years ago

Normalize rsyncmod query data This commit adds an extend method to rsyncmod so that we normalize the hostsallow/hostsdeny keys. We accept them as lists, and we should on query output them as lists. Ticket: #81399

Revision d05eb8ee (diff)
Added by Waqar Ahmed over 2 years ago

Normalize rsyncmod query data This commit adds an extend method to rsyncmod so that we normalize the hostsallow/hostsdeny keys. We accept them as lists, and we should on query output them as lists. Ticket: #81399 (cherry picked from commit 08c104389ed80f0d483cc283530033c2c25177c1)

History

#1 Updated by Chris Jensen over 2 years ago

  • File debug-NASUS-20190316221431.txz added
  • Private changed from No to Yes

#2 Updated by Chris Jensen over 2 years ago

61401

#3 Updated by Chris Jensen over 2 years ago

  • Private changed from Yes to No

#4 Updated by Chris Jensen over 2 years ago

  • Private changed from No to Yes

#5 Updated by Dru Lavigne over 2 years ago

  • Assignee changed from Release Council to Anonymous
  • Target version changed from Backlog to 11.2-U4

#6 Updated by Anonymous over 2 years ago

  • Category changed from GUI (new) to Middleware
  • Assignee changed from Anonymous to William Grzybowski

#7 Updated by Anonymous over 2 years ago Private

I don't see anywhere in the UI code that this is happening, this field is just a text area that lets the user type in whatever they want and feeds it into the backend, could this be happening on the backend perhaps William?

#8 Updated by William Grzybowski over 2 years ago

  • Assignee changed from William Grzybowski to Waqar Ahmed
  • Severity changed from New to Medium

#9 Updated by Bug Clerk over 2 years ago

  • Status changed from Unscreened to In Progress

#10 Updated by Bug Clerk over 2 years ago

  • Status changed from In Progress to Ready for Testing

#11 Updated by Bug Clerk over 2 years ago

  • Target version changed from 11.2-U4 to 11.3-BETA1

#12 Updated by Bug Clerk over 2 years ago

  • Copied to Bug #82713: Validate Allow/Deny Hosts fields in Services -> Rsync -> Rsync Module added

#14 Updated by Dru Lavigne over 2 years ago

  • File deleted (debug-NASUS-20190316221431.txz)

#15 Updated by Dru Lavigne over 2 years ago

  • Status changed from Ready for Testing to Done
  • Target version changed from 11.3-BETA1 to Master - FreeNAS Nightlies
  • Private changed from Yes to No
  • Needs QA changed from Yes to No
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

Also available in: Atom PDF