Project

General

Profile

Bug #82650

Be safer on rm(1) usages

Added by Bug Clerk over 2 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No


Related issues

Related to FreeNAS - Bug #64512: Some upgrades to 11.2 nuke user dataClosed
Copied from FreeNAS - Bug #82641: Be a bit more safer on our rm(1) usagesDone

Associated revisions

Revision 99c1d21d (diff)
Added by William Grzybowski over 2 years ago

Make sure rrdmnt is not / and not /mnt Ticket: #82650

Revision 9d975262 (diff)
Added by William Grzybowski over 2 years ago

Make sure rrdmnt is not / and not /mnt Ticket: #82650

History

#1 Updated by Bug Clerk over 2 years ago

  • Copied from Bug #82641: Be a bit more safer on our rm(1) usages added

#2 Updated by Bug Clerk over 2 years ago

  • Status changed from Unscreened to In Progress

#3 Updated by William Grzybowski over 2 years ago

  • Target version changed from Master - FreeNAS Nightlies to 11.2-U4

#4 Updated by Alexander Motin over 2 years ago

  • Related to Bug #64512: Some upgrades to 11.2 nuke user data added

#5 Updated by Dave F over 2 years ago

Just a suggestion, but maybe target 11.2-U3 to avoid any more cases of data loss.

#6 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Be a bit more safer on our rm(1) usages to Be a bit more safer on rm(1) usages
  • Target version changed from 11.2-U4 to 11.2-U3

#9 Updated by Bug Clerk over 2 years ago

  • Status changed from In Progress to Ready for Testing

#10 Updated by William Grzybowski over 2 years ago

Acceptance Criteria
Make sure manual upgrade still works and reporting graphs (collectd) did not regress

#11 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Be a bit more safer on rm(1) usages to Be safer on rm(1) usages
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#12 Updated by Bonnie Follweiler over 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed FreeNAS-11.2-U3-INTERNAL1

#13 Updated by Dru Lavigne over 2 years ago

  • Status changed from Passed Testing to Done

#14 Updated by Disk Didler over 2 years ago

Out of curiosity, did you guys identify and fix the problem, or you suspect you identified and fixed the problem?

#15 Updated by Dru Lavigne over 2 years ago

We're still trying to reproduce. This fix was an additional safety mechanism after a full code audit.

Also available in: Atom PDF