UFS Disk Import Progress not working
When trying to import a UFS formatted disk, the form fails with "The path None does not exist". I've traced this to the PathField(), where it iterates over mountpoints that already exist. I'm not clear on why this is done or necessary here, so I'm not going to touch it ;-) If we support importing UFS formatted disks, this should work though.
#2 Updated by John Hixson over 5 years ago
The other half of this problem is that in the CIFS sharing UI, PathField() is also used. So let's say I manually create /mnt/ufs0, I mount a UFS disk manually, when I go to share it in the CIFS sharing UI, the same path problem occurs. I'm trying to fix bug #8566, but I'm being roadblocked everywhere ;-)
#3 Updated by Xin Li over 5 years ago
- Assignee changed from Xin Li to Suraj Ravichandran
Over to Suraj as this was introduced by d576fafe9 .
Looking at the code, I think the PathField should probably be initialized with includes = '/mnt/' and have additional clean step to make sure that no existing MountPoint object exists? The current code is asking for a PathField and therefore the import would either fail or shadow an existing file system...
#5 Updated by Suraj Ravichandran over 5 years ago
The PathField exists there as we now only support importing the data on non-zfs filesystems to a current dataset/folder within a pre-existing zfs data pool.
When I revamped this, I was told that we deprecated non-zfs filesystems as data pools with extreme force. Thus this will only allow you to import the disk's contents to a current destination directory specified by the user (hence the PathField).
#10 Updated by Suraj Ravichandran over 5 years ago
- Subject changed from Can't import UFS disk to UFS Disk Import Progress not working
changing the title to fix a bug I found in the progress bar for disk import.
Other than that Import Disk is working properly, with the main intention and goal being as follows:
For any non-zfs data type use the import disk feature and provide the disk (partition) to import, the filesystem type as well as the destination (which should be a dataset in an existing zfs pool in freenas) and the import disk functionality will mount the disk, rsync the files over, unmount the disk.