Project

General

Profile

Bug #8955

UFS Disk Import Progress not working

Added by John Hixson over 5 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
Suraj Ravichandran
Category:
-
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

When trying to import a UFS formatted disk, the form fails with "The path None does not exist". I've traced this to the PathField(), where it iterates over mountpoints that already exist. I'm not clear on why this is done or necessary here, so I'm not going to touch it ;-) If we support importing UFS formatted disks, this should work though.

Associated revisions

Revision 13b68bec (diff)
Added by Suraj Ravichandran over 5 years ago

Fix Import Disk Progress. Ticket: #8955

Revision 46ff0088 (diff)
Added by Suraj Ravichandran over 5 years ago

Add help_text(s) to the Import Disk Form. This has caused some confusion so better to add the tooltip. Ticket: #8955

Revision 04d86cca (diff)
Added by Suraj Ravichandran over 5 years ago

Correct spelling of help_text. Thanks to Jordan for catching this. Ticket: #8955

Revision 61dd907d (diff)
Added by Suraj Ravichandran over 5 years ago

Fix Import Disk Progress. Ticket: #8955 (cherry picked from commit 13b68bec44376f56ece2d895703f2e4ab613404d)

Revision 87ea371c (diff)
Added by Suraj Ravichandran over 5 years ago

Add help_text(s) to the Import Disk Form. This has caused some confusion so better to add the tooltip. Ticket: #8955 (cherry picked from commit 46ff008850de6ae2cffeabc75deae23025c5eaee)

Revision 5a931892 (diff)
Added by Suraj Ravichandran over 5 years ago

Correct spelling of help_text. Thanks to Jordan for catching this. Ticket: #8955 (cherry picked from commit 04d86cca499eb6cdce5ccacecdc78b624934f5fe)

Revision 47f8eaa7 (diff)
Added by Suraj Ravichandran over 5 years ago

Fix Import Disk Progress. Ticket: #8955 (cherry picked from commit 13b68bec44376f56ece2d895703f2e4ab613404d)

Revision 4edbc59d (diff)
Added by Suraj Ravichandran over 5 years ago

Add help_text(s) to the Import Disk Form. This has caused some confusion so better to add the tooltip. Ticket: #8955 (cherry picked from commit 46ff008850de6ae2cffeabc75deae23025c5eaee)

Revision 680287ed (diff)
Added by Suraj Ravichandran over 5 years ago

Correct spelling of help_text. Thanks to Jordan for catching this. Ticket: #8955 (cherry picked from commit 04d86cca499eb6cdce5ccacecdc78b624934f5fe)

History

#1 Updated by Jordan Hubbard over 5 years ago

  • Assignee set to Xin Li

#2 Updated by John Hixson over 5 years ago

The other half of this problem is that in the CIFS sharing UI, PathField() is also used. So let's say I manually create /mnt/ufs0, I mount a UFS disk manually, when I go to share it in the CIFS sharing UI, the same path problem occurs. I'm trying to fix bug #8566, but I'm being roadblocked everywhere ;-)

#3 Updated by Xin Li over 5 years ago

  • Assignee changed from Xin Li to Suraj Ravichandran

Over to Suraj as this was introduced by d576fafe9 .

Looking at the code, I think the PathField should probably be initialized with includes = '/mnt/' and have additional clean step to make sure that no existing MountPoint object exists? The current code is asking for a PathField and therefore the import would either fail or shadow an existing file system...

#4 Updated by Suraj Ravichandran over 5 years ago

  • Status changed from Unscreened to Screened

#5 Updated by Suraj Ravichandran over 5 years ago

The PathField exists there as we now only support importing the data on non-zfs filesystems to a current dataset/folder within a pre-existing zfs data pool.

When I revamped this, I was told that we deprecated non-zfs filesystems as data pools with extreme force. Thus this will only allow you to import the disk's contents to a current destination directory specified by the user (hence the PathField).

#6 Updated by Jordan Hubbard over 5 years ago

What does "import" mean in this context? Mount, copy data, unmount? If yes, we should still support that. If it means "mount permanently and use as a data pool" then no, obviously.

#7 Updated by Suraj Ravichandran over 5 years ago

it means Mount, copy data, unmount atleast ever since d576fafe9

#8 Updated by John Hixson over 5 years ago

So what's going on with this? Are we going to support importing UFS disks or not? ;-)

#9 Updated by Jordan Hubbard over 5 years ago

UFS volumes, sure. I think this thing is misnamed, BTW. :)

#10 Updated by Suraj Ravichandran over 5 years ago

  • Subject changed from Can't import UFS disk to UFS Disk Import Progress not working

changing the title to fix a bug I found in the progress bar for disk import.

Other than that Import Disk is working properly, with the main intention and goal being as follows:

For any non-zfs data type use the import disk feature and provide the disk (partition) to import, the filesystem type as well as the destination (which should be a dataset in an existing zfs pool in freenas) and the import disk functionality will mount the disk, rsync the files over, unmount the disk.

#11 Updated by Suraj Ravichandran over 5 years ago

  • Status changed from Screened to Ready For Release
  • % Done changed from 0 to 100
  • Estimated time set to 1.00 h

#12 Updated by Jordan Hubbard over 5 years ago

  • Status changed from Ready For Release to Resolved

#13 Avatar?id=14398&size=24x24 Updated by Kris Moore about 4 years ago

  • Target version changed from Unspecified to N/A

Also available in: Atom PDF