Project

General

Profile

Bug #8970

CheckForUpdate may not work properly if handler is not set

Added by Sean Fagan over 5 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Nice to have
Assignee:
Sean Fagan
Category:
OS
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

This is a logic error on my part.

Associated revisions

Revision 8c5165c5 (diff)
Added by Sean Fagan over 5 years ago

Don't require "handler" to be set to iterate through the packages. This used to be an optimization -- don't spend time doing the iteration if there's no handler -- but we also set reboot based on the packages. This shouldn't be affecting anything, since CheckFoUpdate should always have a handler, but it leaped out at me as a logic error while investigating with William. Ticket: #8970 Merge-FN93: Yes

Revision e66a0005 (diff)
Added by Sean Fagan over 5 years ago

Don't require "handler" to be set to iterate through the packages. This used to be an optimization -- don't spend time doing the iteration if there's no handler -- but we also set reboot based on the packages. This shouldn't be affecting anything, since CheckFoUpdate should always have a handler, but it leaped out at me as a logic error while investigating with William. Ticket: #8970 Merge-FN93: Yes (cherry picked from commit 8c5165c553490aaad09ceb5cc32a0cf74adedf75)

Revision 57b865c7 (diff)
Added by Sean Fagan over 5 years ago

My logic error fix had a logic error. This seems to work with actual testing, thanks to William. Ticket: #8970 Merge-FN93: Yes

Revision ec3776ce (diff)
Added by Sean Fagan over 5 years ago

My logic error fix had a logic error. This seems to work with actual testing, thanks to William. Ticket: #8970 Merge-FN93: Yes (cherry picked from commit 57b865c7649d24fe2c9b8bc700bf784359e49ef6)

History

#1 Updated by Sean Fagan over 5 years ago

8c5165c553490aaad09ceb5cc32a0cf74adedf75

Hopefully it gets auto-pushed into stable.

#2 Updated by Sean Fagan over 5 years ago

#3 Updated by Sean Fagan over 5 years ago

  • Status changed from Fix In Progress to Resolved
  • ChangeLog Entry updated (diff)

This is done now, I guess.

#4 Avatar?id=14398&size=24x24 Updated by Kris Moore about 4 years ago

  • Seen in changed from Unspecified to N/A

#5 Avatar?id=14398&size=24x24 Updated by Kris Moore about 4 years ago

  • Target version changed from Unspecified to N/A

Also available in: Atom PDF